add verification of communication invariants at the end of spatial

remove dead logic

src/PIM/Conversion/SpatialToPim/BatchCoreLoweringPatterns.cpp

@@ -178,25 +178,6 @@ LogicalResult raptor::SpatialToPimPass::lowerComputeBatchOp(spatial::SpatCompute
     mapper.map(*oldArg, copied);
   }
 
-  auto materializeCapturedTensor = [&](Value capturedTensor) -> Value {
-    if (auto mapped = mapper.lookupOrNull(capturedTensor))
-      return mapped;
-
-    auto capturedType = cast<ShapedType>(capturedTensor.getType());
-    auto outputBuffer = createEmptyTensorFromShaped(rewriter, loc, capturedType);
-    auto copied = pim::PimMemCopyHostToDevBatchOp::create(rewriter,
-                                                          loc,
-                                                          outputBuffer.getType(),
-                                                          outputBuffer,
-                                                          capturedTensor,
-                                                          rewriter.getI32IntegerAttr(0),
-                                                          rewriter.getI32IntegerAttr(0),
-                                                          getTensorSizeInBytesAttr(rewriter, capturedTensor))
-                    .getOutput();
-    mapper.map(capturedTensor, copied);
-    return copied;
-  };
-
   SmallVector<Value> hostOutputTensors(returnOperandIndices.size());
   auto getOrCreateHostOutputTensor = [&](unsigned resultIndex, Location resultLoc) -> Value {
     Value& hostOutputTensor = hostOutputTensors[resultIndex];
@@ -280,7 +261,8 @@ LogicalResult raptor::SpatialToPimPass::lowerComputeBatchOp(spatial::SpatCompute
       if (definingOp && definingOp->getBlock() == &oldBlock)
         continue;
 
-      materializeCapturedTensor(operand);
+      return computeBatchOp.emitOpError(
+        "expected external tensor communication to be materialized in Spatial before batch lowering");
     }
 
     Operation* cloned = rewriter.clone(op, mapper);

src/PIM/Conversion/SpatialToPim/CMakeLists.txt

@@ -10,7 +10,6 @@ add_pim_library(OMSpatialToPim
   ComputeLikeRegionUtils.cpp
   CoreLoweringPatterns.cpp
   GlobalTensorMaterialization.cpp
-  PhaseVerification.cpp
   ReturnPathNormalization.cpp
   TensorPackingPatterns.cpp
 

src/PIM/Conversion/SpatialToPim/PhaseVerification.cpp

@@ -1,20 +0,0 @@
-#include "src/Accelerators/PIM/Conversion/SpatialToPim/PhaseVerification.hpp"
-#include "src/Accelerators/PIM/Dialect/Spatial/SpatialOps.hpp"
-
-using namespace mlir;
-
-namespace onnx_mlir {
-
-LogicalResult verifySpatialToPimBoundary(ModuleOp moduleOp) {
-  bool hasFailure = false;
-  moduleOp.walk([&](Operation* op) {
-    if (op->getDialect()->getNamespace() != "spat")
-      return;
-
-    op->emitError("illegal Spatial operation remains after Spatial-to-PIM lowering");
-    hasFailure = true;
-  });
-  return success(!hasFailure);
-}
-
-} // namespace onnx_mlir

src/PIM/Conversion/SpatialToPim/PhaseVerification.hpp

@@ -1,9 +0,0 @@
-#pragma once
-
-#include "mlir/IR/BuiltinOps.h"
-
-namespace onnx_mlir {
-
-mlir::LogicalResult verifySpatialToPimBoundary(mlir::ModuleOp moduleOp);
-
-} // namespace onnx_mlir

src/PIM/Conversion/SpatialToPim/SpatialToPimPass.cpp

@@ -30,7 +30,6 @@
 #include "Conversion/SpatialToPim/ChannelLoweringPatterns.hpp"
 #include "Conversion/SpatialToPim/Common.hpp"
 #include "Conversion/SpatialToPim/GlobalTensorMaterialization.hpp"
-#include "Conversion/SpatialToPim/PhaseVerification.hpp"
 #include "Conversion/SpatialToPim/TensorPackingPatterns.hpp"
 #include "Dialect/Pim/PimOps.hpp"
 #include "Dialect/Spatial/SpatialOps.hpp"
@@ -284,13 +283,6 @@ void onnx_mlir::raptor::SpatialToPimPass::runOnOperation() {
     signalPassFailure();
     return;
   }
-
-  if (failed(verifySpatialToPimBoundary(moduleOp))) {
-    moduleOp.emitError("Spatial-to-PIM boundary verification failed");
-    signalPassFailure();
-    return;
-  }
-
   // Dump to file for debug
   dumpModule(moduleOp, "pim0");
 }