finally fast googlenet with correct latency artifacts for fair comparison

validation/networks/pimcomp_models/README.md

@@ -4,7 +4,8 @@ This directory contains the four networks evaluated in
 [PIMCOMP: An End-to-End DNN Compiler for Processing-In-Memory Accelerators](https://arxiv.org/pdf/2411.09159):
 VGG-8, ResNet-18, ResNet-34, and GoogLeNet.
 
-See [RESULTS.md](RESULTS.md) for the current latency-only result status.
+See the runner-generated [results.csv](results.csv) for the current latency
+and energy results.
 
 ## Models and provenance
 
@@ -15,11 +16,11 @@ See [RESULTS.md](RESULTS.md) for the current latency-only result status.
 | `googlenet/` | GoogLeNet | `1x3x224x224` | Unmodified [ONNX Model Zoo `googlenet-12`](https://huggingface.co/onnxmodelzoo/googlenet-12). |
 | `vgg8/` | VGG-8 reconstruction | `1x1x28x28` | Deterministic compiler workload with six convolution and two fully connected layers. |
 
-`googlenet/googlenet-12-no-softmax.onnx` is a derived latency model that
-exposes the original model's final FC logits (`loss3/classifier_1`) as its
-output. This matches PIMCOMP's instruction stream, which records but does not
-schedule the terminal `OP_SOFTMAX`. Keep `googlenet-12.onnx` for full-model
-functional validation.
+`googlenet/googlenet-12-latency.onnx` is the explicit common latency model.
+It exposes the original model's final FC logits (`loss3/classifier_1`) and
+removes its two LRN nodes and terminal Softmax so the comparison covers only
+operations scheduled by PIMCOMP. Keep `googlenet-12.onnx` as the unmodified
+source model.
 
 The PIMCOMP authors did not publish the ONNX checkpoints used by the paper.
 Running PIMCOMP's frontend on the three Model Zoo files above produces JSON
@@ -38,7 +39,7 @@ Current SHA-256 checksums:
 788088b908e233d924c7c26b997e89ee861290c7bc56783a306e8201d79aac8f  resnet18/resnet18-v1-7.onnx
 c3231061d081bdd47884137b02134f85142752a39e87263c529cd14ed242b096  resnet34/resnet34-v1-7.onnx
 c99c507058eaf41de8723408fdda7db8325cb57f0a89f2ee07a716d6e963e14e  googlenet/googlenet-12.onnx
-a35bad96441efbee28699cb61d1656cca7f7281f14040cf01699c3d0cfd8b202  googlenet/googlenet-12-no-softmax.onnx
+a26f9e33901c573e60c34a3f0abbb4744fff83e4e0f21b18fc66e20395e72982  googlenet/googlenet-12-latency.onnx
 396cdea21e5e7d02c3f26f14d22ef20975171702493f5c5e79b8e0d896e541ef  vgg8/vgg8-mnist-reconstructed.onnx
 ```
 
@@ -145,17 +146,17 @@ uses the fixed seed `1`, so repeated serial and parallel runs are reproducible.
 ## Compare Raptor and PIMCOMP
 
 The comparison driver uses one random input and one native ONNX-MLIR reference,
-compiles both instruction streams, runs both through `pimsim-nn`, validates
-Raptor through the Rust simulator, and writes Markdown and JSON reports.
-PIMCOMP Rust validation also runs when its optional exporter is available.
+compiles both instruction streams, runs both through `pimsim-nn`, runs
+functional validation through `pim-simulator`, and writes Markdown and JSON
+reports.
 
 To reproduce the complete Arch-A latency experiment, use the model-by-model
 runner. It verifies the paper GA settings, builds Raptor and the existing
 `third_party/PIMCOMP-NN/build` tree, then runs the `element`/batch-1 comparison
-for one model at a time:
+for one model at a time and regenerates `results.csv` from the JSON reports:
 
 ```bash
-.venv/bin/python validation/tools/run_pimcomp_paper_latency.py
+.venv/bin/python validation/tools/pimcomp/run_pimcomp_paper_latency.py
 ```
 
 Each model directory reuses regular validation's ignored `inputs/`, `outputs/`,
@@ -176,7 +177,7 @@ Arch-A low-latency example:
 ```bash
 RAPTOR_ROOT=$PWD
 
-"$RAPTOR_ROOT/.venv/bin/python" "$RAPTOR_ROOT/validation/tools/compare_raptor_pimcomp.py" \
+"$RAPTOR_ROOT/.venv/bin/python" "$RAPTOR_ROOT/validation/tools/pimcomp/compare_raptor_pimcomp.py" \
   --model "$RAPTOR_ROOT/validation/networks/pimcomp_models/resnet34/resnet34-v1-7.onnx" \
   --out-dir "$RAPTOR_ROOT/validation/networks/pimcomp_models/resnet34" \
   --pimcomp-config "$RAPTOR_ROOT/validation/pimsim_configs/pimcomp/arch-a/latency_config.json" \
@@ -202,12 +203,36 @@ The comparison runner enables `--fail-on-error`, so a failed compiler,
 simulation, or semantic validation makes the command fail while preserving the
 generated report.
 
+### Numeric precision and simulator artifacts
+
+The functional and non-functional simulators intentionally consume different
+artifacts:
+
+- Raptor and PIMCOMP are validated against the native ONNX-MLIR reference as
+  FP32 programs in the Rust simulator. Raptor's emitted program is already
+  FP32. The PIMCOMP-to-Rust export expands its element-addressed storage and
+  byte-sized transfers to FP32, emits `setbw 32, 32`, and keeps vector
+  `imm_len` fields as element counts.
+- PIMCOMP's original `SimulationInfo.gz` is copied unchanged for `pimsim-nn`.
+  PIMCOMP hardcodes `setbw 8, 8` and one byte per element without performing
+  numerical quantization; this artifact is used only for latency estimation.
+- Raptor's original FP32 artifact remains unchanged for functional validation.
+  A separate `raptor/pimsim_nn/` view uses `setbw 8, 8` and scales its
+  byte-addressed storage and transfer sizes from four bytes to one byte per
+  element. Vector `imm_len` fields remain element counts. Like PIMCOMP's
+  artifact, this view is not numerically valid and is used only for a fair
+  non-functional comparison.
+
+The ISA defines vector lengths in elements, while `ld`, `st`, `lldi`, `lmv`,
+`send`, `recv`, addresses, and non-vector offsets are byte-based. Do not use
+either latency-only artifact for semantic validation.
+
 Current Raptor status:
 
 - VGG-8, ResNet-18, fixed-batch ResNet-34, and GoogLeNet compile on Arch-A.
-- Use `googlenet-12-no-softmax.onnx` for the paper-matched latency comparison.
-  The original model's final `vsoftmax` is supported by Raptor's functional
-  simulator but not by `pimsim-nn`; PIMCOMP does not schedule that operation.
+- Use `googlenet-12-latency.onnx` for the paper-matched latency comparison.
+  It removes the two LRN nodes and terminal softmax that PIMCOMP does not
+  schedule.
 - Raptor currently accepts one square `--crossbar-size`; Arch-C's rectangular
   `512x1024` arrays can therefore be compiled by PIMCOMP but not compared
   exactly with Raptor.
@@ -227,10 +252,8 @@ rsync -azL validation/networks/pimcomp_models/ \
   "monolith:$REMOTE_REPO/validation/networks/pimcomp_models/"
 rsync -az validation/pimsim_configs/pimcomp/ \
   "monolith:$REMOTE_REPO/validation/pimsim_configs/pimcomp/"
-rsync -az validation/tools/compare_raptor_pimcomp.py \
-  "monolith:$REMOTE_REPO/validation/tools/compare_raptor_pimcomp.py"
-rsync -az validation/tools/run_pimcomp_paper_latency.py \
-  "monolith:$REMOTE_REPO/validation/tools/run_pimcomp_paper_latency.py"
+rsync -az validation/tools/pimcomp/ \
+  "monolith:$REMOTE_REPO/validation/tools/pimcomp/"
 rsync -az --exclude=.git --exclude=build --exclude=output \
   third_party/PIMCOMP-NN/ \
   "monolith:$REMOTE_REPO/third_party/PIMCOMP-NN/"
@@ -247,7 +270,7 @@ python3 -m venv .venv
 .venv/bin/python -m pip install numpy onnx onnxruntime onnxsim colorama
 
 # Run every latency comparison serially.
-.venv/bin/python validation/tools/run_pimcomp_paper_latency.py
+.venv/bin/python validation/tools/pimcomp/run_pimcomp_paper_latency.py
 ```
 
 Copy reports back without transferring large compiler artifacts: