add memory coalescing pass

better reports
refactor for more code-reuse and patter usage
fixes

src/PIM/Pass/PIMPasses.h

@@ -15,6 +15,8 @@ std::unique_ptr<mlir::Pass> createSpatialToPimPass();
 
 std::unique_ptr<mlir::Pass> createPimBufferizationPass();
 
+std::unique_ptr<mlir::Pass> createPimStaticMemoryCoalescingPass();
+
 std::unique_ptr<mlir::Pass> createMergeComputeNodesPass();
 
 std::unique_ptr<mlir::Pass> createPimHostConstantFoldingPass();

src/PIM/Pass/PimCodegen/HostConstantFolding/HostConstantFoldingPass.cpp

@@ -39,7 +39,7 @@ struct HostConstantFoldingPass : PassWrapper<HostConstantFoldingPass, OperationP
       return;
     }
 
-    dumpModule(getOperation(), "pim2_folded");
+    dumpModule(getOperation(), "pim3_folded");
   }
 
   std::shared_ptr<const FrozenRewritePatternSet> patterns;

src/PIM/Pass/PimCodegen/MaterializeHostConstantsPass.cpp

@@ -164,7 +164,7 @@ struct MaterializeHostConstantsPass : PassWrapper<MaterializeHostConstantsPass,
       return;
     }
 
-    dumpModule(moduleOp, "pim3_materialized");
+    dumpModule(moduleOp, "pim4_materialized");
   }
 };
 

src/PIM/Pass/PimCodegen/VerificationPass.cpp

@@ -102,6 +102,35 @@ static bool isExplicitHostOperand(Operation* op, unsigned operandIndex) {
   return false;
 }
 
+static bool isSupportedCoreInstructionOp(Operation* op) {
+  return isa<pim::PimMemCopyHostToDevOp,
+             pim::PimMemCopyHostToDevBatchOp,
+             pim::PimMemCopyDevToHostOp,
+             pim::PimMemCopyOp,
+             pim::PimReceiveOp,
+             pim::PimReceiveBatchOp,
+             pim::PimReceiveTensorOp,
+             pim::PimReceiveTensorBatchOp,
+             pim::PimSendOp,
+             pim::PimSendBatchOp,
+             pim::PimSendTensorOp,
+             pim::PimSendTensorBatchOp,
+             pim::PimConcatOp,
+             pim::PimVMMOp,
+             pim::PimTransposeOp,
+             pim::PimVVAddOp,
+             pim::PimVVSubOp,
+             pim::PimVVMulOp,
+             pim::PimVVMaxOp,
+             pim::PimVVDMulOp,
+             pim::PimVAvgOp,
+             pim::PimVReluOp,
+             pim::PimVTanhOp,
+             pim::PimVSigmOp,
+             pim::PimVSoftmaxOp,
+             memref::GetGlobalOp>(op);
+}
+
 struct VerificationPass : PassWrapper<VerificationPass, OperationPass<ModuleOp>> {
   MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(VerificationPass)
 
@@ -214,6 +243,11 @@ private:
     return walkPimCoreBlock(
       coreOp.getBody().front(), StaticValueKnowledge {}, [](Operation& op, const StaticValueKnowledge& knowledge) {
         bool hasFailure = false;
+        if (!isSupportedCoreInstructionOp(&op)) {
+          op.emitOpError("unsupported executable op reached PIM codegen verification");
+          hasFailure = true;
+        }
+
         for (auto [operandIndex, operand] : llvm::enumerate(op.getOperands())) {
           if (!isa<BaseMemRefType>(operand.getType()))
             continue;