standardize spatial and pim dialects

remove old unused stuff
This commit is contained in:
NiccoloN
2026-03-23 21:21:31 +01:00
parent 0478d979ff
commit 93e20c1dfc
18 changed files with 693 additions and 1519 deletions

View File

@@ -134,366 +134,4 @@ Value sumTensors(ArrayRef<Value> tensors, ConversionPatternRewriter& rewriter) {
return (*currTensors)[0];
}
Value createMapOperation(PatternRewriter& rewriter, MapOperations mapOp, const Value& input) {
switch (mapOp) {
case MapOperations::None: assert(false && "Invalid map operation during map operation creation.");
case MapOperations::ONNXSoftmaxOp: return ONNXSoftmaxOp::create(rewriter, input.getLoc(), input.getType(), input);
case MapOperations::ONNXReluOp: return ONNXReluOp::create(rewriter, input.getLoc(), input.getType(), input);
case MapOperations::ONNXLeakyReluOp: return ONNXLeakyReluOp::create(rewriter, input.getLoc(), input.getType(), input);
case MapOperations::ONNXExpOp: return ONNXExpOp::create(rewriter, input.getLoc(), input.getType(), input);
}
}
void unpackOptionalPairVector(std::optional<mlir::ArrayAttr> valuesArray, size_t& value1, size_t& value2) {
if (auto unpackedStrides = valuesArray) {
value1 = mlir::cast<IntegerAttr>(unpackedStrides->getValue()[0]).getInt();
value2 = mlir::cast<IntegerAttr>(unpackedStrides->getValue()[1]).getInt();
}
else {
value1 = 1;
value2 = 1;
}
}
std::optional<llvm::Twine>
unpackOptionalPadsVector(std::optional<mlir::ArrayAttr> valuesArray, size_t& pad_x, size_t& pad_y) {
if (valuesArray.has_value()) {
auto pads = mlir::ArrayAttr(*valuesArray);
if (pads.size() != 4)
return "pads must have 4 elements.";
pad_x = cast<IntegerAttr>(pads[2]).getInt();
pad_y = cast<IntegerAttr>(pads[3]).getInt();
}
else {
// Default padding is 0 unless specified otherwise.
// https://onnx.ai/onnx/operators/onnx__Conv.html
pad_x = pad_y = 0;
}
return std::nullopt;
}
void tileImageTensorByChannel(Value imageTensor,
SmallVector<SmallVector<SmallVector<Value>>>& tiles,
size_t tileSize,
ConversionPatternRewriter& rewriter) {
ShapedType imageShape = mlir::cast<ShapedType>(imageTensor.getType());
size_t input_h = getImageHeight(imageShape);
size_t input_w = getImageWidth(imageShape);
size_t tileCount = ceilIntegerDivide(getImageChannel(imageShape), tileSize);
size_t tileRest = getImageChannel(imageShape) % tileSize;
SmallVector<OpFoldResult> strides(4, rewriter.getIndexAttr(1));
SmallVector<OpFoldResult> offsets(4, rewriter.getIndexAttr(0));
SmallVector<OpFoldResult> sizes = {
rewriter.getIndexAttr(1), rewriter.getIndexAttr(tileSize), rewriter.getIndexAttr(1), rewriter.getIndexAttr(1)};
Location loc = imageTensor.getLoc();
for (size_t i = 0; i < tileCount; i++) {
if (i == tileCount - 1 && tileRest != 0)
sizes[1] = rewriter.getIndexAttr(tileRest);
for (size_t x = 0; x < input_w; x++) {
for (size_t y = 0; y < input_h; y++) {
offsets[1] = rewriter.getIndexAttr(i * tileSize);
offsets[2] = rewriter.getIndexAttr(x);
offsets[3] = rewriter.getIndexAttr(y);
tiles[i][x][y] = tensor::ExtractSliceOp::create(rewriter, loc, imageTensor, offsets, sizes, strides);
}
}
}
}
Value createImgConcatOp(SmallVector<SmallVector<SmallVector<Value>>>& outputTiles,
ConversionPatternRewriter& rewriter,
Location& loc,
Type outputType) {
// Populate the outputTiles for the concat in the given order:
// 1. Start top left pixel
// 2. Continue on its right pixel till the end of the row
// 3. Restart on the next row
size_t outputTileCount = outputTiles.size();
size_t output_w = outputTiles[0].size();
size_t output_h = outputTiles[0][0].size();
SmallVector<Value> tilesToConcat;
tilesToConcat.reserve(output_h * output_w * outputTileCount * crossbarSize);
for (size_t outX = 0; outX < output_h; outX++)
for (size_t outY = 0; outY < output_w; outY++)
for (size_t outTile = 0; outTile < outputTileCount; outTile++)
tilesToConcat.push_back(outputTiles[outTile][outX][outY]);
return spatial::SpatImgConcatOp::create(rewriter, loc, outputType, tilesToConcat);
}
LogicalResult
verifyWithinBoundsAndPaddings(size_t input_w, size_t input_h, int inX, int inY, size_t pad_x, size_t pad_y) {
if (inX < 0) {
assert((size_t) (-inX) <= pad_x && "verifyWithinBoundsAndPaddings: Negative x value out of padding");
return failure();
}
if (inY < 0) {
assert((size_t) (-inY) <= pad_y && "verifyWithinBoundsAndPaddings: Negative y value out of padding");
return failure();
}
if ((size_t) inX >= input_w || (size_t) inY >= input_h) {
assert((size_t) inX < input_w + pad_x && "verifyWithinBoundsAndPaddings: Positive x out of bounds");
assert((size_t) inY < input_h + pad_y && "verifyWithinBoundsAndPaddings: Positive y out of bounds");
return failure();
}
return success();
}
Value createExtractSliceImg(Value valToSlice,
size_t x,
size_t y,
size_t t,
size_t channelTileCount,
size_t channelTileRest,
size_t input_w,
size_t input_h,
PatternRewriter& rewriter) {
SmallVector<OpFoldResult> strides(4, rewriter.getIndexAttr(1));
SmallVector<OpFoldResult> offsets(4, rewriter.getIndexAttr(0));
SmallVector<OpFoldResult> sizes = {
rewriter.getIndexAttr(1), rewriter.getIndexAttr(crossbarSize), rewriter.getIndexAttr(1), rewriter.getIndexAttr(1)};
if (t == channelTileCount - 1 && channelTileRest != 0)
sizes[1] = rewriter.getIndexAttr(channelTileRest);
offsets[1] = rewriter.getIndexAttr(t * crossbarSize);
offsets[2] = rewriter.getIndexAttr(x);
offsets[3] = rewriter.getIndexAttr(y);
return tensor::ExtractSliceOp::create(rewriter, valToSlice.getLoc(), valToSlice, offsets, sizes, strides);
}
Value indexImgValue(Value v,
size_t x,
size_t y,
size_t t,
size_t channelTileCount,
size_t channelTileRest,
size_t input_w,
size_t input_h,
ConversionPatternRewriter& rewriter) {
auto newV = rewriter.getRemappedValue(v);
if (newV)
v = newV;
if (!v.getDefiningOp())
return createExtractSliceImg(v, x, y, t, channelTileCount, channelTileRest, input_w, input_h, rewriter);
if (auto computeOp = v.getDefiningOp<spatial::SpatWeightedCompute>()) {
// We found the computeOp that produces the tile we want, just return this
// value.
// TODO: Should we assert that x,y,t are zero?
assert(x == 0 && y == 0 && t == 0 && "indexImgValue: WeightedComputeOp tile indeces should be zero");
return v;
}
if (auto receiveOp = v.getDefiningOp<spatial::SpatChannelReceiveOp>()) {
// This is a receiveOp, just return its value which will be resolved later
assert(x == 0 && y == 0 && t == 0 && "indexImgValue: receiveOp tile indeces should be zero");
return v;
}
if (auto imgConcatOp = v.getDefiningOp<spatial::SpatImgConcatOp>()) {
auto imgConcatInput = imgConcatOp.getInputTile(x, y, t);
// TODO: Is this correct?
// Above we already index exactly the tile we want, so `x=y=t=0` in
// recursive call
return indexImgValue(imgConcatInput, 0, 0, 0, channelTileCount, channelTileRest, input_w, input_h, rewriter);
}
if (auto tensorConcatOp = v.getDefiningOp<tensor::ConcatOp>()) {
// This can be recursive.
// First, get the input tensors of the tensor.concatOp
// Then, find the input tensor that contains the tile we want
// Finally, recursive call asking for the tile
auto concatAxis = tensorConcatOp.getDim();
assert(concatAxis != 0 && "Expecting to concat on channel/x/y axis");
assert(concatAxis == 1 && "TODO: Make sure this works and makes sense for other axis.");
SmallVector<size_t, 4> indexDims = {1, t * crossbarSize, x, y};
// Find the input tensor that contains the tile we want
size_t currentTile = 0;
for (auto concatInput : tensorConcatOp.getInputs()) {
auto concatInputShape = cast<ShapedType>(concatInput.getType());
assert(concatInputShape.getRank() == 4 && "Expecting an image tensor");
auto concatInputSizeOnAxis = concatInputShape.getDimSize(concatAxis);
if (currentTile + concatInputSizeOnAxis > indexDims[concatAxis]) {
// This input tensor contains the tile we want
indexDims[concatAxis] -= currentTile;
if (indexDims[1] % crossbarSize != 0) {
assert(ignoreConcatError
&& "TODO: Handle non-tile aligned tensor, or set "
"--ignore-concat-error=true");
}
return indexImgValue(concatInput,
indexDims[2],
indexDims[3],
indexDims[1] / crossbarSize,
channelTileCount,
channelTileRest,
input_w,
input_h,
rewriter);
}
currentTile += concatInputSizeOnAxis;
}
assert(false
&& "Could not find the input tensor that contains the tile "
"within tensor.ConcatOp");
}
v.dump();
assert(false && "indexImgValue: unsupported operation");
}
void resolveInputTensorTilesBlockArg(Value wholeInputTensor,
SmallVector<SmallVector<SmallVector<Value>>>& inputTiles,
size_t channelTileCount,
size_t channelTileRest,
size_t input_w,
size_t input_h,
PatternRewriter& rewriter) {
SmallVector<OpFoldResult> strides(4, rewriter.getIndexAttr(1));
SmallVector<OpFoldResult> offsets(4, rewriter.getIndexAttr(0));
SmallVector<OpFoldResult> sizes = {
rewriter.getIndexAttr(1), rewriter.getIndexAttr(crossbarSize), rewriter.getIndexAttr(1), rewriter.getIndexAttr(1)};
Location loc = wholeInputTensor.getLoc();
for (size_t t = 0; t < channelTileCount; t++) {
if (t == channelTileCount - 1 && channelTileRest != 0)
sizes[1] = rewriter.getIndexAttr(channelTileRest);
for (size_t x = 0; x < input_w; x++) {
for (size_t y = 0; y < input_h; y++) {
offsets[1] = rewriter.getIndexAttr(t * crossbarSize);
offsets[2] = rewriter.getIndexAttr(x);
offsets[3] = rewriter.getIndexAttr(y);
inputTiles[t][x][y] = tensor::ExtractSliceOp::create(rewriter, loc, wholeInputTensor, offsets, sizes, strides);
}
}
}
}
std::optional<Twine> resolveImgInputTiles(Value wholeInputTensor,
SmallVector<SmallVector<SmallVector<Value>>>& inputTiles,
size_t channelTileCount,
size_t channelTileRest,
size_t input_w,
size_t input_h,
ConversionPatternRewriter& rewriter) {
for (size_t t = 0; t < channelTileCount; t++) {
for (size_t x = 0; x < input_w; x++) {
for (size_t y = 0; y < input_h; y++) {
inputTiles[t][x][y] =
indexImgValue(wholeInputTensor, x, y, t, channelTileCount, channelTileRest, input_w, input_h, rewriter);
}
}
}
return std::nullopt;
}
LogicalResult handleFlattenLikeOp(SmallVector<SmallVector<Value>>& inputTiles,
const size_t inputTilesCount,
const size_t lastInputTileDimension,
TensorType inputShape,
TensorType outputShape,
Value reshapeInput,
ConversionPatternRewriter& rewriter) {
// Only support reshape between an image and a vector (i.e. flatten)
if (inputShape.getRank() != 4 || outputShape.getRank() != 2) {
return rewriter.notifyMatchFailure(reshapeInput.getDefiningOp(),
"resolveVecInputTiles only supports reshapes from 4D to 2D tensors");
}
/*
* From a 4D tensor <N, C, W, H> to a 2D tensor <N, C*H*W>
*/
auto N = inputShape.getDimSize(0);
auto C = inputShape.getDimSize(1);
auto H = inputShape.getDimSize(2);
auto W = inputShape.getDimSize(3);
assert(N == 1 && "Only support N = 1 for image tensors");
for (size_t i = 0; i < inputTilesCount; i++) {
auto c = (i / (H * W)) % C;
// TODO: Is this correct? Or should I invert h and w?
auto w = (i / H) % W;
auto h = i % H;
Value curTile = indexImgValue(reshapeInput, w, h, c, inputTilesCount, lastInputTileDimension, W, H, rewriter);
// Assert the shape of the tile, and reshape it
auto curTileShape = cast<TensorType>(curTile.getType());
assert(curTileShape.getRank() == 4 && "We just reshaped an image tensor, why rank != 4?");
assert(curTileShape.getDimSize(0) == 1 && "We just reshaped an image tensor with N = 1, why is it now != 1?");
assert(curTileShape.getDimSize(2) == 1 && "We should have just looked up a single pixel why W != 1?");
assert(curTileShape.getDimSize(3) == 1 && "We should have just looked up a single pixel why H != 1?");
// Reshape this pixel tensor into a vector, for compatibility with the
// rest
SmallVector<int64_t> newShapeVals = {curTileShape.getDimSize(0), curTileShape.getDimSize(1)};
auto shapeType = RankedTensorType::get({static_cast<int64_t>(newShapeVals.size())}, rewriter.getI64Type());
Value shapeTensor =
arith::ConstantOp::create(rewriter, reshapeInput.getLoc(), DenseIntElementsAttr::get(shapeType, newShapeVals));
auto reshapedType = RankedTensorType::get(newShapeVals, curTileShape.getElementType());
auto reshapedCurTile = tosa::ReshapeOp::create(rewriter, reshapeInput.getLoc(), reshapedType, curTile, shapeTensor);
size_t coreIndex = i / crossbarCountInCore;
inputTiles[coreIndex].push_back(reshapedCurTile);
}
return success();
}
std::pair<size_t, size_t> kernel_get_start_and_end(
int64_t out_pos, int64_t input_width, int64_t krn_width, int64_t stride, int64_t dilation, int64_t pad) {
int64_t firstValid = std::ceil(static_cast<float>(pad) / dilation) * dilation - pad;
int64_t start = std::max(firstValid, out_pos * stride - pad);
int64_t end = std::min(input_width, out_pos * stride + (krn_width - 1) * dilation + 1 - pad);
assert(start >= 0 && "Start position must be non-negative.");
assert(end >= 0 && "End position must be non-negative.");
return std::make_pair(start, end);
}
void incrementWeightedComputeInputsSegmentSize(spatial::SpatWeightedCompute wcomputeOp, int increment) {
auto oldSegmentSizes = wcomputeOp->getAttrOfType<DenseI32ArrayAttr>(wcomputeOp.getOperandSegmentSizesAttrName());
auto newSegmentSizes =
DenseI32ArrayAttr::get(wcomputeOp->getContext(), {oldSegmentSizes[0], oldSegmentSizes[1] + increment});
wcomputeOp->setAttr(wcomputeOp.getOperandSegmentSizesAttrName(), newSegmentSizes);
}
int getResultIndex(Operation* op, Value v) {
int resultNumber = -1;
for (auto result : op->getResults()) {
if (result == v) {
resultNumber = result.getResultNumber();
break;
}
}
assert(resultNumber >= 0 && "Value not found in given operation's results.");
return resultNumber;
}
}; // namespace onnx_mlir

View File

@@ -2,7 +2,6 @@
#include "mlir/Dialect/Tensor/IR/Tensor.h"
#include "mlir/IR/BuiltinTypes.h"
#include "mlir/IR/Operation.h"
#include "mlir/IR/PatternMatch.h"
#include "mlir/Support/LLVM.h"
#include "mlir/Transforms/DialectConversion.h"
@@ -10,7 +9,6 @@
#include "llvm/Support/LogicalResult.h"
#include <cassert>
#include <cstddef>
#include <optional>
#include <type_traits>
#include <utility>
@@ -144,164 +142,4 @@ mlir::tensor::SplatOp broadcastToVector(mlir::Value scalarToBroadcast,
mlir::Value sumTensors(mlir::ArrayRef<mlir::Value> tensors, mlir::ConversionPatternRewriter& rewriter);
mlir::Value createMapOperation(mlir::PatternRewriter& rewriter, MapOperations mapOp, const mlir::Value& input);
/**
* Unpacks an optional pair vector into two size_t values.
*
* @param valuesArray The optional `mlir::ArrayAttr` containing the pair of
* values.
* @param value1 The reference to the first `size_t` variable to store the
* unpacked value.
* @param value2 The reference to the second `size_t` variable to store the
* unpacked value.
*/
void unpackOptionalPairVector(std::optional<mlir::ArrayAttr> valuesArray, size_t& value1, size_t& value2);
/**
* Unpacks the optional pads vector.
*
* @param valuesArray The optional array attribute containing the values.
* @param pad_x The output variable to store the value of pad_x.
* @param pad_y The output variable to store the value of pad_y.
* @param rewriter The rewriter to notify failure
*
* @return llvm::Optional<llvm::Twine> The error message if the pads are invalid
*/
std::optional<llvm::Twine>
unpackOptionalPadsVector(std::optional<mlir::ArrayAttr> valuesArray, size_t& pad_x, size_t& pad_y);
/**
* Tiles the image tensor by channel.
*
* This function takes an image tensor and tiles it into smaller tiles based on
* the channel dimension. The size of each tile is specified by the tileSize
* parameter.
*
* @param imageTensor The input image tensor (NxCxWxH) to be tiled.
* @param tiles The output tiles vector to store the tiled image tensors.
* @param tileSize The size of each tile.
* @param rewriter The ConversionPatternRewriter used for creating operations.
*/
void tileImageTensorByChannel(mlir::Value imageTensor,
llvm::SmallVector<llvm::SmallVector<llvm::SmallVector<mlir::Value>>>& tiles,
size_t tileSize,
mlir::ConversionPatternRewriter& rewriter);
/**
* Creates an ImgConcatOp based on the given tiles.
*
* This function takes a 3-dimensional vector `outputTiles` representing the
* tiles to concatenate. The tiles are indexed by [tile][x][y].
*
* @param outputTiles The tiles to concatenate.
* @param rewriter The ConversionPatternRewriter used for creating the
* ImgConcatOp.
* @param loc The location of the operation.
* @param outputType The type of the output tensor.
*
* @return The created ImgConcatOp.
*/
mlir::Value createImgConcatOp(llvm::SmallVector<llvm::SmallVector<llvm::SmallVector<mlir::Value>>>& outputTiles,
mlir::ConversionPatternRewriter& rewriter,
mlir::Location& loc,
mlir::Type outputType);
/**
* @brief Verifies if the given input coordinates and padding values are within
* the bounds of the input tensor.
*
* @param input_w The width of the input tensor.
* @param input_h The height of the input tensor.
* @param inX The X-coordinate of the input.
* @param inY The Y-coordinate of the input.
* @param pad_x The padding value in the X-direction.
* @param pad_y The padding value in the Y-direction.
* @return LogicalResult Returns success if the coordinates and padding are
* within bounds, failure otherwise.
*/
mlir::LogicalResult
verifyWithinBoundsAndPaddings(size_t input_w, size_t input_h, int inX, int inY, size_t pad_x, size_t pad_y);
/**
* Resolves the tiling of the input tensor into smaller tiles.
*
* This function takes a whole input tensor and tiles it into smaller tiles
* using the provided parameters. The resulting tiles are stored in the
* `inputTiles` vector.
* Input tiles need to be indexed by:
* a. Channel Tile
* b. Pixel `x` position
* c. Pixel `y` position
* For example: inputTiles[channelTile][x][y]
*
* @param wholeInputTensor The whole input tensor to be tiled.
* @param inputTiles A vector of vectors of vectors of Values representing the
* tiles of the input tensor. The outermost vector represents
* the channels, the middle vector represents the rows, and
* the innermost vector represents the columns of the tiles.
* @param channelTileCount The number of tiles for the `channel` axis.
* @param channelTileRest The size of the last channelTile. Set as 0 if tiles
* fit exactly
* @param input_w The width of the input tensor.
* @param input_h The height of the input tensor.
* @param rewriter The ConversionPatternRewriter used for creating operations.
*
* @return std::optional<llvm::Twine> An error message if the input tensor could
* not be resolved into tiles.
*/
std::optional<llvm::Twine>
resolveImgInputTiles(mlir::Value wholeInputTensor,
llvm::SmallVector<llvm::SmallVector<llvm::SmallVector<mlir::Value>>>& inputTiles,
size_t channelTileCount,
size_t channelTileRest,
size_t input_w,
size_t input_h,
mlir::ConversionPatternRewriter& rewriter);
/**
* Computes the boundaries of an image kernel application.
*
* @param out_pos The position of the output element.
* @param input_width The width of the input image.
* @param krn_width The width of the kernel.
* @param stride The stride value.
* @param dilation The dilation value.
* @param pad The padding value.
* @return A pair of size_t values representing the start and end positions of
* the kernel application.
*/
std::pair<size_t, size_t> kernel_get_start_and_end(
int64_t out_pos, int64_t input_width, int64_t krn_width, int64_t stride, int64_t dilation, int64_t pad);
/**
* @brief Increment the `operandSegmentSizes` in the WeightedCompute operation
* for the `inputs` operand.
*
* This function increments the size of the `inputs` operand segment in the
* `operandSegmentSizes` of the given WeightedCompute operation by the specified
* increment. This is necessary when new operands are programmatically added to
* the WeightedCompute operation.
*
* @param wcomputeOp The WeightedCompute operation whose `operandSegmentSizes`
* is to be incremented.
* @param increment The value by which to increment the `inputs` operand segment
* size.
*/
void incrementWeightedComputeInputsSegmentSize(spatial::SpatWeightedCompute wcomputeOp, int increment);
/**
* @brief Finds the result index of the given operation that produces the
* specified value.
*
* This function takes an operation and a value, and returns the index of the
* result of the operation that corresponds to the given value.
*
* @param op Operation whose result index is to be found.
* @param v The value for which the result index is to be determined.
* @return The index of the result of the operation that produces the specified
* value.
*/
int getResultIndex(mlir::Operation* op, mlir::Value v);
}; // namespace onnx_mlir

View File

@@ -223,9 +223,6 @@ void SpatialToGraphvizPass::runOnOperation() {
else if (auto concatOp = dyn_cast<tensor::ConcatOp>(op)) {
drawConcatOpSubgraph(concatOp, concatNum++);
}
else if (auto imgConcatOp = dyn_cast<spatial::SpatImgConcatOp>(op)) {
drawConcatOpSubgraph(imgConcatOp, concatNum++);
}
else if (auto extractSliceOp = dyn_cast<tensor::ExtractSliceOp>(op)) {
auto producerOp = extractSliceOp->getOperand(0).getDefiningOp();
if (producerOp) {

View File

@@ -45,8 +45,4 @@ createEmptyTensorFromShaped(mlir::IRRewriter& rewriter, mlir::Location loc, mlir
return mlir::tensor::EmptyOp::create(rewriter, loc, shapedType.getShape(), shapedType.getElementType());
}
inline bool isAConcatOp(mlir::Operation* op) {
return llvm::isa<mlir::tensor::ConcatOp>(op) || llvm::isa<spatial::SpatImgConcatOp>(op);
}
} // namespace onnx_mlir

View File

@@ -45,4 +45,5 @@ def spatToPimVVMaxOp : Pat<
(NativeCodeCall<"onnx_mlir::getBestOutputTensorFromOperandsOrAllocate($_builder, $0.getDefiningOp())"> $srcOpRes))
>;
#endif // SPATIAL_TO_PIM

View File

@@ -278,7 +278,7 @@ void SpatialToPimPass::runOnComputeOp(spatial::SpatWeightedCompute computeOp, IR
continue;
}
if (isa<tensor::ConcatOp>(resultUser) || isa<spatial::SpatImgConcatOp>(resultUser)) {
if (isa<tensor::ConcatOp>(resultUser)) {
auto concatOp = resultUser;
auto concatValue = concatOp->getResult(0);
auto concatUses = concatValue.getUses();
@@ -368,8 +368,8 @@ void SpatialToPimPass::enlargeVMMOutTensorsToCrossbarSize(func::FuncOp funcOp, I
};
funcOp.walk([&](PimVMMOp vmmOp) {
auto outTensorOperand = vmmOp.getOutBuf();
auto resultTensor = vmmOp.getOutRes();
auto outTensorOperand = vmmOp.getOutputBuffer();
auto resultTensor = vmmOp.getOutput();
auto outShape = getTensorShape(outTensorOperand);
assert(isHVectorShape(outShape));
if (outShape[1] != static_cast<int64_t>(crossbarSize)) {
@@ -602,9 +602,7 @@ void SpatialToPimPass::replaceReturnOpOperands(func::ReturnOp& returnOp, IRRewri
rewriter.modifyOpInPlace(returnOp,
[&] { returnOp.setOperand(orderWithinReturn, outputTensors[orderWithinReturn]); });
// If the operand is a concatenation operation and the returnOp was the only
// user of the returnOperand, we can safely remove it
if (isAConcatOp(returnOperand)) {
if (isa<tensor::ConcatOp>(returnOperand)) {
auto returnOperandUses = it.value().getUses();
if (rangeLength(returnOperandUses) == 0)
rewriter.eraseOp(returnOperand);
@@ -632,7 +630,7 @@ void SpatialToPimPass::runOnReceiveOp(spatial::SpatChannelReceiveOp receiveOp, I
// user. This means that we need to get the replace the original SendOp with
// a BroadcastSendOp
rewriter.setInsertionPoint(sendOp);
rewriter.replaceOpWithNewOp<spatial::SpatChannelBroadcastSendOp>(sendOp, sendOp.getChannel(), sendOp.getData());
rewriter.replaceOpWithNewOp<spatial::SpatChannelBroadcastSendOp>(sendOp, sendOp.getChannel(), sendOp.getInput());
}
}