compact memory contiguity with for loops

src/PIM/Compiler/PimCodeGen.cpp

@@ -235,6 +235,7 @@ size_t PimAcceleratorMemory::getValueAddress(mlir::Value value,
     if (failed(compiledExpr)) {
       errs() << "Failed to compile contiguous address for value: ";
       value.print(errs());
+      errs() << " : " << value.getType();
       errs() << "\n";
       llvm_unreachable("Failed to compile contiguous address");
     }
@@ -245,6 +246,7 @@ size_t PimAcceleratorMemory::getValueAddress(mlir::Value value,
   if (failed(resolvedAddress)) {
     errs() << "Failed to evaluate contiguous address for value: ";
     value.print(errs());
+    errs() << " : " << value.getType();
     errs() << "\n";
     if (auto* definingOp = value.getDefiningOp()) {
       errs() << "Defining op:\n";
@@ -493,11 +495,15 @@ void PimCodeGen::codeGenStoreOp(pim::PimMemCopyDevToHostOp storeOp, const Static
 }
 
 void PimCodeGen::codeGenLmvOp(pim::PimMemCopyOp lmvOp, const StaticValueKnowledge& knowledge) const {
+  auto targetOffset = indexOf(lmvOp.getTargetOffset(), knowledge);
+  auto sourceOffset = indexOf(lmvOp.getSourceOffset(), knowledge);
+  assert(succeeded(targetOffset) && succeeded(sourceOffset)
+         && "pim.memcp offsets must be statically resolvable during codegen");
   emitMemCopyOp("lmv",
                 addressOf(lmvOp.getTarget(), knowledge),
-                lmvOp.getTargetOffset(),
+                *targetOffset,
                 addressOf(lmvOp.getSource(), knowledge),
-                lmvOp.getSourceOffset(),
+                *sourceOffset,
                 lmvOp.getSize(),
                 "len");
 }