update PIMCOMP fork

validation/raptor_validation/validate_one.py

@@ -254,7 +254,7 @@ def pimcomp_compatibility_errors(config_path, *, core_count, crossbar_count, cro
 def run_pimsim_nn(pimsim_nn_build_dir, pim_dir, config_path, reporter=None, timeout_sec=None):
     try:
         output = run_command(
-            [pimsim_nn_build_dir / "ChipTest", pim_dir, config_path, "false"],
+            [pimsim_nn_build_dir / "ChipTest", pim_dir, config_path, "--gui=false"],
             cwd=pimsim_nn_build_dir,
             reporter=reporter,
             timeout_sec=timeout_sec,
@@ -416,8 +416,6 @@ def validate_network(network_onnx_path, raptor_path, onnx_include_dir,
         pimsim_nn_build_dir = Path(pimsim_nn_build_dir).resolve()
         pimsim_config_path = Path(pimsim_config_path).resolve()
     compile_extra_args = list(raptor_extra_args or [])
-    if pimsim_enabled and "--pim-emit-json" not in compile_extra_args:
-        compile_extra_args.append("--pim-emit-json")
     owns_reporter = reporter is None
     reporter = reporter or ProgressReporter(model_total, stages_per_model=len(MODE_STAGE_TITLES[mode]), verbose=verbose)
 

validation/tools/compare_raptor_pimcomp.py

@@ -817,7 +817,6 @@ def run_pimsim_nn(
     label: str,
     inst_path: Path,
     config_path: Path,
-    single_file: bool,
     steps: list[StepRecord],
     args: argparse.Namespace,
 ) -> dict[str, Any]:
@@ -825,7 +824,7 @@ def run_pimsim_nn(
         str(args.pimsim_nn_build_dir / "ChipTest"),
         str(inst_path),
         str(config_path),
-        "true" if single_file else "false",
+        "--gui=false",
     ]
     output = run_logged(
         label,
@@ -1239,7 +1238,7 @@ def main():
     reuse_raptor = args.reuse_raptor_report is not None
 
     raptor_validation = skipped_validation("Raptor validation did not run")
-    pimcomp_validation = skipped_validation("PIMCOMP validation did not run")
+    pimcomp_validation = failed_validation("PIMCOMP validation did not run")
     raptor_perf: dict[str, Any] = skipped_perf("pimsim-nn Raptor did not run")
     pimcomp_perf: dict[str, Any] = skipped_perf("pimsim-nn PIMCOMP did not run")
     raptor_instr: dict[str, Any] = empty_instruction_summary("Raptor instruction parsing did not run")
@@ -1412,14 +1411,14 @@ def main():
     elif verification_info is None or simulation_info is None:
         record_failure(
             failures,
-            "Skip PIMCOMP Rust export",
-            "PIMCOMP Rust export was skipped because PIMCOMP did not produce VerificationInfo.json and SimulationInfo.gz.",
+            "Export PIMCOMP for Rust",
+            "PIMCOMP Rust export failed because PIMCOMP did not produce VerificationInfo.json and SimulationInfo.gz.",
         )
     else:
         record_failure(
             failures,
-            "Skip PIMCOMP Rust export",
-            "PIMCOMP Rust export was skipped because model inputs are not available.",
+            "Export PIMCOMP for Rust",
+            "PIMCOMP Rust export failed because model inputs are not available.",
         )
 
     if pimcomp_export_dir is not None and reference_dir is not None and outputs_desc:
@@ -1438,11 +1437,11 @@ def main():
         )
         pimcomp_validation = validation if validation is not None else failed_validation("PIMCOMP validation failed")
     elif pimcomp_export_dir is None:
-        pimcomp_validation = skipped_validation("PIMCOMP Rust export is not available")
+        pimcomp_validation = failed_validation("PIMCOMP Rust export is not available")
     elif reference_dir is None:
-        pimcomp_validation = skipped_validation("Reference outputs are not available")
+        pimcomp_validation = failed_validation("Reference outputs are not available")
     else:
-        pimcomp_validation = skipped_validation("Output descriptors are not available")
+        pimcomp_validation = failed_validation("Output descriptors are not available")
 
     if not args.skip_pimsim_nn and hardware["core_count"] > 0:
         written_config = try_stage(
@@ -1478,7 +1477,6 @@ def main():
                 "pimsim-nn Raptor",
                 raptor_pim_dir,
                 pimsim_config,
-                False,
                 steps,
                 args,
             )
@@ -1502,7 +1500,6 @@ def main():
                     "pimsim-nn PIMCOMP",
                     pimcomp_pimsim_dir,
                     pimsim_config,
-                    False,
                     steps,
                     args,
                 )